PMD Results

The following document contains the results of PMD 5.6.1.

Files

org/dbunit/IOperationListener.java

Violation Line
Avoid modifiers which are implied by the context 44
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 58
Avoid modifiers which are implied by the context 68–81

org/dbunit/ant/AbstractStep.java

Violation Line
Useless parentheses. 143

org/dbunit/ant/DbUnitTaskStep.java

Violation Line
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 40

org/dbunit/ant/Operation.java

Violation Line
Avoid unused imports such as 'org.apache.tools.ant.types.Resource' 26
Avoid unused imports such as 'java.util.Iterator' 44

org/dbunit/assertion/DifferenceListener.java

Violation Line
Avoid modifiers which are implied by the context 43

org/dbunit/assertion/FailureFactory.java

Violation Line
Avoid modifiers which are implied by the context 43
Avoid modifiers which are implied by the context 50

org/dbunit/assertion/FailureHandler.java

Violation Line
Avoid modifiers which are implied by the context 46–47

org/dbunit/database/DatabaseConfig.java

Violation Line
These nested if statements could be combined 265–268

org/dbunit/database/DatabaseDataSet.java

Violation Line
These nested if statements could be combined 401–404

org/dbunit/database/DatabaseTableMetaData.java

Violation Line
Useless parentheses. 369

org/dbunit/database/IDatabaseConnection.java

Violation Line
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 55
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 70–71
Avoid modifiers which are implied by the context 83–84
Avoid modifiers which are implied by the context 96–97
Avoid modifiers which are implied by the context 105–106
Avoid modifiers which are implied by the context 114
Avoid modifiers which are implied by the context 123
Avoid modifiers which are implied by the context 128
Avoid modifiers which are implied by the context 133

org/dbunit/database/IMetadataHandler.java

Violation Line
Avoid modifiers which are implied by the context 63–64
Avoid modifiers which are implied by the context 126–127

org/dbunit/database/IResultSetTable.java

Violation Line
Avoid modifiers which are implied by the context 34

org/dbunit/database/IResultSetTableFactory.java

Violation Line
Avoid modifiers which are implied by the context 37–38
Avoid modifiers which are implied by the context 40–41
Avoid modifiers which are implied by the context 51–52

org/dbunit/database/PrimaryKeyFilter.java

Violation Line
Useless parentheses. 492

org/dbunit/dataset/DefaultTable.java

Violation Line
Avoid empty catch blocks 144–148

org/dbunit/dataset/IDataSet.java

Violation Line
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 49–50
Avoid modifiers which are implied by the context 61
Avoid modifiers which are implied by the context 69
Avoid modifiers which are implied by the context 74
Avoid modifiers which are implied by the context 79
Avoid modifiers which are implied by the context 86

org/dbunit/dataset/IRowValueProvider.java

Violation Line
Avoid modifiers which are implied by the context 40

org/dbunit/dataset/ITable.java

Violation Line
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 44
Avoid modifiers which are implied by the context 57

org/dbunit/dataset/ITableIterator.java

Violation Line
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 44
Avoid modifiers which are implied by the context 49

org/dbunit/dataset/ITableMetaData.java

Violation Line
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 57
Avoid modifiers which are implied by the context 67

org/dbunit/dataset/common/handlers/AbstractPipelineComponent.java

Violation Line
These nested if statements could be combined 91–92

org/dbunit/dataset/common/handlers/Handler.java

Violation Line
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 35

org/dbunit/dataset/datatype/DataType.java

Violation Line
Avoid unused imports such as 'java.time.Clock' 28
Avoid unused imports such as 'java.time.Instant' 29
Avoid unused imports such as 'java.time.ZoneId' 30

org/dbunit/dataset/datatype/DateDataType.java

Violation Line
Avoid empty catch blocks 110–113

org/dbunit/dataset/datatype/IDataTypeFactory.java

Violation Line
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 55–56

org/dbunit/dataset/datatype/IDbProductRelatable.java

Violation Line
Avoid modifiers which are implied by the context 41

org/dbunit/dataset/datatype/TimeDataType.java

Violation Line
Unnecessary use of fully qualified name 'java.sql.Time' due to existing import 'java.sql.Time' 69
Unnecessary use of fully qualified name 'java.sql.Time' due to existing import 'java.sql.Time' 77
Unnecessary use of fully qualified name 'java.sql.Time' due to existing import 'java.sql.Time' 83
Unnecessary use of fully qualified name 'java.sql.Time.valueOf' due to existing import 'java.sql.Time' 97
Unnecessary use of fully qualified name 'java.sql.Time.valueOf' due to existing import 'java.sql.Time' 106
Unnecessary use of fully qualified name 'java.sql.Time' due to existing import 'java.sql.Time' 145

org/dbunit/dataset/datatype/TimestampDataType.java

Violation Line
Avoid unused imports such as 'java.time.Clock' 30
Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 75
Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 83
Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 89
Unnecessary use of fully qualified name 'java.sql.Timestamp.valueOf' due to existing import 'java.sql.Timestamp' 103
Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 125
Avoid empty catch blocks 126–129
Unnecessary use of fully qualified name 'java.sql.Timestamp.valueOf' due to existing import 'java.sql.Timestamp' 135
Unnecessary use of fully qualified name 'java.util.TimeZone.getDefault' due to existing import 'java.util.TimeZone' 147
Useless parentheses. 154
Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 208

org/dbunit/dataset/excel/XlsTable.java

Violation Line
Avoid unused imports such as 'java.util.TimeZone' 29
Useless parentheses. 262
These nested if statements could be combined 264–268

org/dbunit/dataset/filter/IColumnFilter.java

Violation Line
Avoid modifiers which are implied by the context 46

org/dbunit/dataset/filter/IRowFilter.java

Violation Line
Avoid modifiers which are implied by the context 39

org/dbunit/dataset/filter/ITableFilter.java

Violation Line
Avoid modifiers which are implied by the context 43
Avoid modifiers which are implied by the context 50–51

org/dbunit/dataset/filter/ITableFilterSimple.java

Violation Line
Avoid modifiers which are implied by the context 38

org/dbunit/dataset/filter/PatternMatcher.java

Violation Line
Avoid using a branching statement as the last in a loop. 281

org/dbunit/dataset/stream/IDataSetConsumer.java

Violation Line
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 55
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 67

org/dbunit/dataset/stream/IDataSetProducer.java

Violation Line
Avoid modifiers which are implied by the context 35
Avoid modifiers which are implied by the context 46

org/dbunit/dataset/stream/StreamingIterator.java

Violation Line
Avoid empty while statements 121

org/dbunit/dataset/xml/FlatDtdProducer.java

Violation Line
Useless parentheses. 228

org/dbunit/dataset/xml/FlatDtdWriter.java

Violation Line
Useless parentheses. 168
Useless parentheses. 208

org/dbunit/dataset/xml/XmlProducer.java

Violation Line
Useless parentheses. 196
Useless parentheses. 326

org/dbunit/ext/db2/Db2MetadataHandler.java

Violation Line
These nested if statements could be combined 97–103

org/dbunit/ext/mckoi/MckoiDataTypeFactory.java

Violation Line
Useless parentheses. 70
Useless parentheses. 71
Useless parentheses. 72
Useless parentheses. 74
Useless parentheses. 75
Useless parentheses. 76
Useless parentheses. 77
Useless parentheses. 78
Useless parentheses. 79
Useless parentheses. 81
Useless parentheses. 82
Useless parentheses. 83
Useless parentheses. 84
Useless parentheses. 85
Useless parentheses. 87
Useless parentheses. 88
Useless parentheses. 89
Useless parentheses. 90
Useless parentheses. 91
Useless parentheses. 92
Useless parentheses. 93
Useless parentheses. 94
Useless parentheses. 95
Useless parentheses. 97
Useless parentheses. 98
Useless parentheses. 99
Useless parentheses. 100
Useless parentheses. 101

org/dbunit/ext/mssql/InsertIdentityOperation.java

Violation Line
Useless parentheses. 105
Useless parentheses. 114

org/dbunit/ext/mssql/MsSqlDataTypeFactory.java

Violation Line
These nested if statements could be combined 75–78

org/dbunit/ext/mysql/MySqlDataTypeFactory.java

Violation Line
These nested if statements could be combined 99–101

org/dbunit/ext/oracle/OracleBlobDataType.java

Violation Line
Avoid unused imports such as 'oracle.sql.BLOB' 23
Unnecessary use of fully qualified name 'oracle.sql.BLOB' due to existing import 'oracle.sql.BLOB' 74
Unnecessary use of fully qualified name 'oracle.sql.BLOB.createTemporary' due to existing import 'oracle.sql.BLOB' 77
Unnecessary use of fully qualified name 'oracle.sql.BLOB.DURATION_SESSION' due to existing import 'oracle.sql.BLOB' 77
Unnecessary use of fully qualified name 'oracle.sql.BLOB.MODE_READWRITE' due to existing import 'oracle.sql.BLOB' 78
Unnecessary use of fully qualified name 'oracle.sql.BLOB' due to existing import 'oracle.sql.BLOB' 108

org/dbunit/ext/oracle/OracleSdoElemInfoArray.java

Violation Line
Useless parentheses. 148
Useless parentheses. 148

org/dbunit/ext/oracle/OracleSdoGeometryDataType.java

Violation Line
Avoid unused imports such as 'java.sql.Connection' 25

org/dbunit/ext/oracle/OracleSdoHelper.java

Violation Line
Useless parentheses. 40
Useless parentheses. 41
Useless parentheses. 43–45

org/dbunit/ext/oracle/OracleSdoOrdinateArray.java

Violation Line
Useless parentheses. 148
Useless parentheses. 148

org/dbunit/ext/oracle/OracleSdoPointType.java

Violation Line
Useless parentheses. 122
Useless parentheses. 122

org/dbunit/ext/postgresql/PostgreSQLOidDataType.java

Violation Line
Unnecessary use of fully qualified name 'org.postgresql.PGConnection' due to existing import 'org.postgresql.PGConnection' 93

org/dbunit/operation/AbstractBatchOperation.java

Violation Line
Avoid empty catch blocks 226–232

org/dbunit/operation/InsertOperation.java

Violation Line
Useless parentheses. 123
Useless parentheses. 146
Useless parentheses. 146

org/dbunit/operation/RefreshOperation.java

Violation Line
Avoid empty catch blocks 119–125
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 360

org/dbunit/util/Base64.java

Violation Line
Avoid unused private fields such as 'BAD_ENCODING'. 124
Avoid unused local variables such as 'ib'. 154
Avoid empty while statements 156–157
Avoid unused private methods such as 'encode3to4(byte)'. 179
Useless parentheses. 250
Useless parentheses. 251
Useless parentheses. 252
Useless parentheses. 257
Useless parentheses. 264
Useless parentheses. 271
Useless parentheses. 380

org/dbunit/util/SQLHelper.java

Violation Line
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 76
Useless parentheses. 365
These nested if statements could be combined 622–623
These nested if statements could be combined 639–640
Useless parentheses. 658

org/dbunit/util/concurrent/BoundedBuffer.java

Violation Line
Useless parentheses. 151
Useless parentheses. 195

org/dbunit/util/concurrent/BoundedChannel.java

Violation Line
Avoid modifiers which are implied by the context 37

org/dbunit/util/concurrent/BoundedLinkedQueue.java

Violation Line
Useless parentheses. 274

org/dbunit/util/concurrent/Channel.java

Violation Line
Avoid modifiers which are implied by the context 249
Avoid modifiers which are implied by the context 267
Avoid modifiers which are implied by the context 280
Avoid modifiers which are implied by the context 299
Avoid modifiers which are implied by the context 306

org/dbunit/util/concurrent/Executor.java

Violation Line
Avoid modifiers which are implied by the context 69

org/dbunit/util/concurrent/LinkedQueue.java

Violation Line
Useless parentheses. 190

org/dbunit/util/concurrent/PropertyChangeMulticaster.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 421
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 422

org/dbunit/util/concurrent/Puttable.java

Violation Line
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 69

org/dbunit/util/concurrent/Sync.java

Violation Line
Avoid modifiers which are implied by the context 273
Avoid modifiers which are implied by the context 299
Avoid modifiers which are implied by the context 313
Avoid modifiers which are implied by the context 316
Avoid modifiers which are implied by the context 319
Avoid modifiers which are implied by the context 322
Avoid modifiers which are implied by the context 325
Avoid modifiers which are implied by the context 328
Avoid modifiers which are implied by the context 334
Avoid modifiers which are implied by the context 337

org/dbunit/util/concurrent/SynchronizedInt.java

Violation Line
Useless parentheses. 85
Useless parentheses. 238

org/dbunit/util/concurrent/Takable.java

Violation Line
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 65

org/dbunit/util/xml/XmlWriter.java

Violation Line
Do not use if statements that are always true or always false 383
Useless parentheses. 748
Useless parentheses. 780–781
Useless parentheses. 780
Useless parentheses. 780
Useless parentheses. 781
Avoid unused private methods such as 'replace(String,String,String)'. 785–786